test(jindo): add missing unit tests for JindoEngine SyncRuntime#5996
test(jindo): add missing unit tests for JindoEngine SyncRuntime#5996Sukuna0007Abhi wants to merge 2 commits into
Conversation
Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Sukuna0007Abhi. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors TestJindoEngine_SyncRuntime in pkg/ddc/jindo/sync_runtime_test.go by removing unused commented-out fields and arguments to simplify the test setup. Feedback suggests initializing the embedded Context field in cruntime.ReconcileRequestContext with context.TODO() to prevent potential nil pointer dereference panics during test execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…inter dereference Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
|
|
Plz review @cheyang @TrafalgarZZZ |
1 participant
Ⅰ. Describe what this PR does
This PR adds missing unit tests for the
SyncRuntimemethod in theJindoEngine. It uses table-driven testing to cover the default logic ofSyncRuntime, which currently logs the sync and returnstrue, nil. This improves the overall code coverage for the Jindo runtime package.Ⅱ. Does this pull request fix one or more issues?
fixes #5995
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
TestJindoEngine_SyncRuntimeadded topkg/ddc/jindo/sync_runtime_test.goⅣ. Describe how to verify it